Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: LayoutTests/compositing/squashing/squashing-into-ancestor-painted-layer.html

Issue 476583002: Fix a bogus assertion in CLM (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: . Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/compositing/squashing/squashing-into-ancestor-painted-layer-expected.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/compositing/squashing/squashing-into-ancestor-painted-layer.html
diff --git a/LayoutTests/compositing/ancestor-painted-layer-should-appear-expected.html b/LayoutTests/compositing/squashing/squashing-into-ancestor-painted-layer.html
similarity index 64%
copy from LayoutTests/compositing/ancestor-painted-layer-should-appear-expected.html
copy to LayoutTests/compositing/squashing/squashing-into-ancestor-painted-layer.html
index afb764a1ac638d3d9cdf459ad10db18aa31482c5..8003e0463f0699a240421e2ac40d1aaa6220e144 100644
--- a/LayoutTests/compositing/ancestor-painted-layer-should-appear-expected.html
+++ b/LayoutTests/compositing/squashing/squashing-into-ancestor-painted-layer.html
@@ -1,4 +1,12 @@
<!DOCTYPE HTML>
+<!--
+ This test creates a scenario where we attempt to squash into a layer that
+ paints into its composited ancestor. This should not crash.
+
+ It also happens that we shouldn't promote |container| in this case as its
+ composited descendants are invisible, but that's a separate bug. See,
+ crbug.com/403894.
+-->
<style>
body {
-webkit-transform: translateZ(0);
@@ -14,7 +22,6 @@ body {
#container {
-webkit-perspective: 1400px;
- -webkit-transform: translateZ(0);
position: absolute;
width: 180px;
height: 180px;
@@ -24,14 +31,15 @@ body {
#composited {
width: 100px;
height: 100px;
+ left: 200px;
background: green;
position: absolute;
-webkit-transform: translateZ(10px);
+ visibility: hidden;
}
#squashed {
position: absolute;
- left: 200px;
width: 50px;
height: 50px;
background: blue;
@@ -42,4 +50,4 @@ body {
<div id="composited"></div>
</div>
<div id="squashed"></div>
-
+THIS TEST PASSES IF IT DOES NOT CRASH
« no previous file with comments | « no previous file | LayoutTests/compositing/squashing/squashing-into-ancestor-painted-layer-expected.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698