Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: Source/core/dom/Document.cpp

Issue 476553002: Navigation transitions: Hide transition elements by setting CSS opacity rather than display. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Test fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/html/navigation-transition-expected.txt ('k') | Source/core/testing/Internals.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index ad901ee9f0a31e05ae7cdc8c6c3551b5b8e5ab1d..192507b09cb5a8146bf9fe4526e22c2a946d291b 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -5641,7 +5641,7 @@ void Document::hideTransitionElements(const AtomicString& cssSelector)
for (unsigned nodeIndex = 0; nodeIndex < nodeListLength; ++nodeIndex) {
Element* element = elementList->item(nodeIndex);
- element->setInlineStyleProperty(CSSPropertyDisplay, CSSValueNone);
+ element->setInlineStyleProperty(CSSPropertyOpacity, 0.0, CSSPrimitiveValue::CSS_NUMBER);
}
}
}
« no previous file with comments | « LayoutTests/fast/html/navigation-transition-expected.txt ('k') | Source/core/testing/Internals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698