Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 476553002: Navigation transitions: Hide transition elements by setting CSS opacity rather than display. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Test fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 5623 matching lines...) Expand 10 before | Expand all | Expand 10 after
5634 5634
5635 void Document::hideTransitionElements(const AtomicString& cssSelector) 5635 void Document::hideTransitionElements(const AtomicString& cssSelector)
5636 { 5636 {
5637 TrackExceptionState exceptionState; 5637 TrackExceptionState exceptionState;
5638 RefPtrWillBeRawPtr<StaticElementList> elementList = querySelectorAll(cssSele ctor, exceptionState); 5638 RefPtrWillBeRawPtr<StaticElementList> elementList = querySelectorAll(cssSele ctor, exceptionState);
5639 if (elementList && !exceptionState.hadException()) { 5639 if (elementList && !exceptionState.hadException()) {
5640 unsigned nodeListLength = elementList->length(); 5640 unsigned nodeListLength = elementList->length();
5641 5641
5642 for (unsigned nodeIndex = 0; nodeIndex < nodeListLength; ++nodeIndex) { 5642 for (unsigned nodeIndex = 0; nodeIndex < nodeListLength; ++nodeIndex) {
5643 Element* element = elementList->item(nodeIndex); 5643 Element* element = elementList->item(nodeIndex);
5644 element->setInlineStyleProperty(CSSPropertyDisplay, CSSValueNone); 5644 element->setInlineStyleProperty(CSSPropertyOpacity, 0.0, CSSPrimitiv eValue::CSS_NUMBER);
5645 } 5645 }
5646 } 5646 }
5647 } 5647 }
5648 5648
5649 bool Document::hasFocus() const 5649 bool Document::hasFocus() const
5650 { 5650 {
5651 Page* page = this->page(); 5651 Page* page = this->page();
5652 if (!page) 5652 if (!page)
5653 return false; 5653 return false;
5654 if (!page->focusController().isActive() || !page->focusController().isFocuse d()) 5654 if (!page->focusController().isActive() || !page->focusController().isFocuse d())
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
5790 using namespace blink; 5790 using namespace blink;
5791 void showLiveDocumentInstances() 5791 void showLiveDocumentInstances()
5792 { 5792 {
5793 WeakDocumentSet& set = liveDocumentSet(); 5793 WeakDocumentSet& set = liveDocumentSet();
5794 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 5794 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
5795 for (WeakDocumentSet::const_iterator it = set.begin(); it != set.end(); ++it ) { 5795 for (WeakDocumentSet::const_iterator it = set.begin(); it != set.end(); ++it ) {
5796 fprintf(stderr, "- Document %p URL: %s\n", *it, (*it)->url().string().ut f8().data()); 5796 fprintf(stderr, "- Document %p URL: %s\n", *it, (*it)->url().string().ut f8().data());
5797 } 5797 }
5798 } 5798 }
5799 #endif 5799 #endif
OLDNEW
« no previous file with comments | « LayoutTests/fast/html/navigation-transition-expected.txt ('k') | Source/core/testing/Internals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698