Chromium Code Reviews

Issue 476543003: Stop RenderProgress timer on destruction. (Closed)

Created:
6 years, 4 months ago by sof
Modified:
6 years, 4 months ago
Reviewers:
tkent, haraken, esprehn, rune, Julien - ping for review
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink, Xianzhu, oilpan-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Stop RenderProgress timer on destruction. To handle the Oilpan case where the RenderObject stays around until the next GC after the object has been destroy()ed, stop the RenderProgress animation timer. R=tkent@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180536

Patch Set 1 #

Patch Set 2 : Stop RenderProgress timer on destroy() #

Unified diffs Side-by-side diffs Stats (+10 lines, -0 lines)
M Source/core/rendering/RenderProgress.h View 1 chunk +1 line, -0 lines 0 comments
M Source/core/rendering/RenderProgress.cpp View 1 chunk +9 lines, -0 lines 0 comments

Messages

Total messages: 9 (0 generated)
sof
Please take a look. Somewhat of a speculative null pointer fix, Oilpan bots are currently ...
6 years, 4 months ago (2014-08-19 07:02:04 UTC) #1
tkent
In Oilpan, RenderObject is alive after destroy() until the next GC. RenderProgress should override destroy(), ...
6 years, 4 months ago (2014-08-19 07:15:05 UTC) #2
sof
On 2014/08/19 07:15:05, tkent wrote: > In Oilpan, RenderObject is alive after destroy() until the ...
6 years, 4 months ago (2014-08-19 07:29:52 UTC) #3
tkent
lgtm
6 years, 4 months ago (2014-08-19 07:41:41 UTC) #4
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-19 07:49:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/476543003/20001
6 years, 4 months ago (2014-08-19 07:50:35 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-19 08:50:40 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (20001) as 180536
6 years, 4 months ago (2014-08-19 09:21:50 UTC) #8
haraken
6 years, 4 months ago (2014-08-19 11:37:24 UTC) #9
Message was sent while issue was closed.
LGTM

Powered by Google App Engine