Change the lifespan of SSlConnectJobMessengers so that they are created

Change the lifespan of SSlConnectJobMessengers so that they are created
only when needed, and deleted as soon as they are no longer necessary.

Add methods to SSLClientSocketPool that are passed to the SSLConnectJob
and SSLConnectJobMessenger as callbacks. These allow the SSLConnectJob
to tell the SSLClientSocketPool to create a messenger for the job when
appropriate, and the SSLConnectJobMessenger to tell the
SSLCLientSocketPool to remove a messenger when appropriate. An
SSLConnectJob will now only create an SSLConnectJobMessenger if its
socket's session is not already in the session cache. The messenger
will then ask to be removed when there are no remaining pending or
connecting sockets in the messenger.

Written by Mackenzie Shelley <mshelley@chromium.org>;
Original review URL: https://codereview.chromium.org/384873002/

R=rsleevi@chromium.org
TBR=mek@chromium.org
BUG=398967
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291192

[wtc, 2014-08-16 01:34:25]

Ryan: please review the entire CL.

Marijn: please review ssl_client_socket.h and tls_socket_unittest.cc.

[wtc, 2014-08-20 21:15:56]

The CQ bit was checked by wtc@chromium.org

[commit-bot: I haz the power, 2014-08-20 21:16:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wtc@chromium.org/476313004/20001

[Ryan Sleevi, 2014-08-20 22:04:43]

lgtm

[Ryan Sleevi, 2014-08-20 22:06:35]

bah, published from wrong tab. One nit.

https://codereview.chromium.org/476313004/diff/20001/net/socket/ssl_client_so...
File net/socket/ssl_client_socket_pool.h (right):

https://codereview.chromium.org/476313004/diff/20001/net/socket/ssl_client_so...
net/socket/ssl_client_socket_pool.h:121: SSLConnectJobMessenger(const
base::Closure& messenger_finished_callback);
explicit

[wtc, 2014-08-20 22:23:33]

The CQ bit was unchecked by wtc@chromium.org

[wtc, 2014-08-20 22:26:44]

Thanks for the review.

https://codereview.chromium.org/476313004/diff/20001/net/socket/ssl_client_so...
File net/socket/ssl_client_socket_pool.h (right):

https://codereview.chromium.org/476313004/diff/20001/net/socket/ssl_client_so...
net/socket/ssl_client_socket_pool.h:121: SSLConnectJobMessenger(const
base::Closure& messenger_finished_callback);
On 2014/08/20 22:06:35, Ryan Sleevi wrote:
> explicit

Done.

[wtc, 2014-08-20 22:26:51]

The CQ bit was checked by wtc@chromium.org

[commit-bot: I haz the power, 2014-08-20 22:27:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wtc@chromium.org/476313004/40001

[commit-bot: I haz the power, 2014-08-21 00:19:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-21 00:22:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-21 00:22:34]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[wtc, 2014-08-21 18:08:28]

The CQ bit was checked by wtc@chromium.org

[commit-bot: I haz the power, 2014-08-21 18:11:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wtc@chromium.org/476313004/40001

[commit-bot: I haz the power, 2014-08-21 21:30:59]

Committed patchset #3 (40001) as 291192