Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: net/socket/ssl_client_socket_nss.cc

Issue 476313004: Change the lifespan of SSlConnectJobMessengers so that they are created (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Mark the SSLConnectJobMessenger constructor as explicit Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/socket/ssl_client_socket_nss.h ('k') | net/socket/ssl_client_socket_openssl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file includes code SSLClientSocketNSS::DoVerifyCertComplete() derived 5 // This file includes code SSLClientSocketNSS::DoVerifyCertComplete() derived
6 // from AuthCertificateCallback() in 6 // from AuthCertificateCallback() in
7 // mozilla/security/manager/ssl/src/nsNSSCallbacks.cpp. 7 // mozilla/security/manager/ssl/src/nsNSSCallbacks.cpp.
8 8
9 /* ***** BEGIN LICENSE BLOCK ***** 9 /* ***** BEGIN LICENSE BLOCK *****
10 * Version: MPL 1.1/GPL 2.0/LGPL 2.1 10 * Version: MPL 1.1/GPL 2.0/LGPL 2.1
(...skipping 2816 matching lines...) Expand 10 before | Expand all | Expand 10 after
2827 << " for cipherSuite " << cipher_suite; 2827 << " for cipherSuite " << cipher_suite;
2828 } 2828 }
2829 2829
2830 ssl_info->handshake_type = core_->state().resumed_handshake ? 2830 ssl_info->handshake_type = core_->state().resumed_handshake ?
2831 SSLInfo::HANDSHAKE_RESUME : SSLInfo::HANDSHAKE_FULL; 2831 SSLInfo::HANDSHAKE_RESUME : SSLInfo::HANDSHAKE_FULL;
2832 2832
2833 LeaveFunction(""); 2833 LeaveFunction("");
2834 return true; 2834 return true;
2835 } 2835 }
2836 2836
2837 std::string SSLClientSocketNSS::GetSessionCacheKey() const {
2838 NOTIMPLEMENTED();
2839 return std::string();
2840 }
2841
2837 bool SSLClientSocketNSS::InSessionCache() const { 2842 bool SSLClientSocketNSS::InSessionCache() const {
2838 // For now, always return true so that SSLConnectJobs are never held back. 2843 // For now, always return true so that SSLConnectJobs are never held back.
2839 return true; 2844 return true;
2840 } 2845 }
2841 2846
2842 void SSLClientSocketNSS::SetHandshakeCompletionCallback( 2847 void SSLClientSocketNSS::SetHandshakeCompletionCallback(
2843 const base::Closure& callback) { 2848 const base::Closure& callback) {
2844 NOTIMPLEMENTED(); 2849 NOTIMPLEMENTED();
2845 } 2850 }
2846 2851
(...skipping 695 matching lines...) Expand 10 before | Expand all | Expand 10 after
3542 scoped_refptr<X509Certificate> 3547 scoped_refptr<X509Certificate>
3543 SSLClientSocketNSS::GetUnverifiedServerCertificateChain() const { 3548 SSLClientSocketNSS::GetUnverifiedServerCertificateChain() const {
3544 return core_->state().server_cert.get(); 3549 return core_->state().server_cert.get();
3545 } 3550 }
3546 3551
3547 ChannelIDService* SSLClientSocketNSS::GetChannelIDService() const { 3552 ChannelIDService* SSLClientSocketNSS::GetChannelIDService() const {
3548 return channel_id_service_; 3553 return channel_id_service_;
3549 } 3554 }
3550 3555
3551 } // namespace net 3556 } // namespace net
OLDNEW
« no previous file with comments | « net/socket/ssl_client_socket_nss.h ('k') | net/socket/ssl_client_socket_openssl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698