Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 476303002: Remove obsolete HitTestResult.targetNode (Closed)

Created:
6 years, 4 months ago by Rick Byers
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-events_chromium.org, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Remove obsolete HitTestResult.targetNode This has been an alias for innerNode with a "remove this" FIXME for some time. The cleanup is pretty easy. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181786

Patch Set 1 #

Patch Set 2 : Fix Mac build #

Patch Set 3 : Merge with trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -40 lines) Patch
M Source/core/page/EventHandler.cpp View 1 2 27 chunks +30 lines, -30 lines 0 comments Download
M Source/core/page/EventWithHitTestResults.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/HitTestResult.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/HitTestResult.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/web/mac/WebSubstringUtil.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Rick Byers
Zeeshan, PTAL when you get a chance. This is an entirely mechanical cleanup (with the ...
6 years, 4 months ago (2014-08-15 21:15:54 UTC) #1
Zeeshan Qureshi
lgtm
6 years, 4 months ago (2014-08-18 23:19:31 UTC) #2
Rick Byers
+aelias for source/web OWNERS I was waiting on this until after merging hit-test fixes back ...
6 years, 3 months ago (2014-09-10 15:24:44 UTC) #4
aelias_OOO_until_Jul13
lgtm
6 years, 3 months ago (2014-09-10 16:07:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/476303002/40001
6 years, 3 months ago (2014-09-11 01:28:14 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 03:08:48 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 181786

Powered by Google App Engine
This is Rietveld 408576698