Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: Source/core/rendering/HitTestResult.h

Issue 476303002: Remove obsolete HitTestResult.targetNode (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Merge with trunk Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/page/EventWithHitTestResults.h ('k') | Source/core/rendering/HitTestResult.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Computer, Inc. 2 * Copyright (C) 2006 Apple Computer, Inc.
3 * Copyright (C) 2012 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2012 Nokia Corporation and/or its subsidiary(-ies)
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 void append(const HitTestResult&); 128 void append(const HitTestResult&);
129 129
130 // If m_rectBasedTestResult is 0 then set it to a new NodeSet. Return *m_rec tBasedTestResult. Lazy allocation makes 130 // If m_rectBasedTestResult is 0 then set it to a new NodeSet. Return *m_rec tBasedTestResult. Lazy allocation makes
131 // sense because the NodeSet is seldom necessary, and it's somewhat expensiv e to allocate and initialize. This method does 131 // sense because the NodeSet is seldom necessary, and it's somewhat expensiv e to allocate and initialize. This method does
132 // the same thing as mutableRectBasedTestResult(), but here the return value is const. 132 // the same thing as mutableRectBasedTestResult(), but here the return value is const.
133 const NodeSet& rectBasedTestResult() const; 133 const NodeSet& rectBasedTestResult() const;
134 134
135 // Collapse the rect-based test result into a single target at the specified location. 135 // Collapse the rect-based test result into a single target at the specified location.
136 void resolveRectBasedTest(Node* resolvedInnerNode, const LayoutPoint& resolv edPointInMainFrame); 136 void resolveRectBasedTest(Node* resolvedInnerNode, const LayoutPoint& resolv edPointInMainFrame);
137 137
138 // FIXME: Remove this.
139 Node* targetNode() const { return innerNode(); }
140
141 private: 138 private:
142 KURL absoluteImageURLInternal(bool allowCanvas) const; 139 KURL absoluteImageURLInternal(bool allowCanvas) const;
143 NodeSet& mutableRectBasedTestResult(); // See above. 140 NodeSet& mutableRectBasedTestResult(); // See above.
144 HTMLMediaElement* mediaElement() const; 141 HTMLMediaElement* mediaElement() const;
145 142
146 HitTestLocation m_hitTestLocation; 143 HitTestLocation m_hitTestLocation;
147 144
148 RefPtrWillBeMember<Node> m_innerNode; 145 RefPtrWillBeMember<Node> m_innerNode;
149 RefPtrWillBeMember<Node> m_innerPossiblyPseudoNode; 146 RefPtrWillBeMember<Node> m_innerPossiblyPseudoNode;
150 RefPtrWillBeMember<Node> m_innerNonSharedNode; 147 RefPtrWillBeMember<Node> m_innerNonSharedNode;
151 // FIXME: Nothing changes this to a value different from m_hitTestLocation! 148 // FIXME: Nothing changes this to a value different from m_hitTestLocation!
152 LayoutPoint m_pointInInnerNodeFrame; // The hit-tested point in innerNode fr ame coordinates. 149 LayoutPoint m_pointInInnerNodeFrame; // The hit-tested point in innerNode fr ame coordinates.
153 LayoutPoint m_localPoint; // A point in the local coordinate space of m_inne rNonSharedNode's renderer. Allows us to efficiently 150 LayoutPoint m_localPoint; // A point in the local coordinate space of m_inne rNonSharedNode's renderer. Allows us to efficiently
154 // determine where inside the renderer we hit on s ubsequent operations. 151 // determine where inside the renderer we hit on s ubsequent operations.
155 RefPtrWillBeMember<Element> m_innerURLElement; 152 RefPtrWillBeMember<Element> m_innerURLElement;
156 RefPtr<Scrollbar> m_scrollbar; 153 RefPtr<Scrollbar> m_scrollbar;
157 bool m_isOverWidget; // Returns true if we are over a widget (and not in the border/padding area of a RenderWidget for example). 154 bool m_isOverWidget; // Returns true if we are over a widget (and not in the border/padding area of a RenderWidget for example).
158 bool m_isFirstLetter; 155 bool m_isFirstLetter;
159 156
160 mutable OwnPtrWillBeMember<NodeSet> m_rectBasedTestResult; 157 mutable OwnPtrWillBeMember<NodeSet> m_rectBasedTestResult;
161 }; 158 };
162 159
163 } // namespace blink 160 } // namespace blink
164 161
165 #endif // HitTestResult_h 162 #endif // HitTestResult_h
OLDNEW
« no previous file with comments | « Source/core/page/EventWithHitTestResults.h ('k') | Source/core/rendering/HitTestResult.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698