mojo/services/public/interfaces/input_events/input_events.mojom - Issue 476283006: mojo: Fix double character inserts on Windows by removing a Linux hack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/public/interfaces/input_events/input_events.mojom

Issue 476283006: mojo: Fix double character inserts on Windows by removing a Linux hack. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move input method to its own file. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/services/public/cpp/input_events/lib/mojo_extended_key_event_data.cc ('k') | mojo/views/input_method_mojo_linux.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/public/interfaces/input_events/input_events.mojom

diff --git a/mojo/services/public/interfaces/input_events/input_events.mojom b/mojo/services/public/interfaces/input_events/input_events.mojom

index aa3d577ccdf74575bab14583ce0f58b916b488cd..6faaa5f0d03c063bd1f9cae6ddd025b122008baa 100644

--- a/mojo/services/public/interfaces/input_events/input_events.mojom

+++ b/mojo/services/public/interfaces/input_events/input_events.mojom

@@ -25,7 +25,12 @@ struct KeyData {

// not do this until we remove ui::Event usage from within mojo.

int32 key_code;

+ // Whether this is a character event, and the character value if it is. Note

+ // that this is different than |text|, which holds a value even when there

+ // isn't actually a character to insert. (For example, |text| will be set and

+ // have a value on backspace, and |character| won't.)

bool is_char;

+ uint16 character;

// The Win32 key code. Because of the web, this is the closest thing that we

// have to a cross platform key state.

« no previous file with comments | « mojo/services/public/cpp/input_events/lib/mojo_extended_key_event_data.cc ('k') | mojo/views/input_method_mojo_linux.h » ('j') | no next file with comments »