Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4239)

Unified Diff: chrome/browser/extensions/api/system_display/display_info_provider.h

Issue 476103002: Make DisplayInfoProvider an interface (Closed) Base URL: git@github.com:tmpsantos/chromium.git@display_info
Patch Set: Fixed GN and Windows build Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/system_display/display_info_provider.h
diff --git a/chrome/browser/extensions/api/system_display/display_info_provider.h b/chrome/browser/extensions/api/system_display/display_info_provider.h
index 50eec2e0d1484401959ee65922f0fbdbbac4f27c..13995606000a7bdfac067bc2f4f44cbc71b539fe 100644
--- a/chrome/browser/extensions/api/system_display/display_info_provider.h
+++ b/chrome/browser/extensions/api/system_display/display_info_provider.h
@@ -23,7 +23,6 @@ class DisplayInfoProvider {
public :
static DisplayInfoProvider* Get();
- DisplayInfoProvider();
virtual ~DisplayInfoProvider();
// This is for tests that run in its own process (e.g. browser_tests).
@@ -34,14 +33,17 @@ class DisplayInfoProvider {
virtual bool SetInfo(const std::string& display_id,
James Cook 2014/08/15 19:58:42 Please document this method.
const api::system_display::DisplayProperties& info,
- std::string* error);
+ std::string* error) = 0;
+
+ protected:
+ DisplayInfoProvider();
private:
// Update the content of the |unit| obtained for |display| using
// platform specific method.
virtual void UpdateDisplayUnitInfoForPlatform(
const gfx::Display& display,
- extensions::api::system_display::DisplayUnitInfo* unit);
+ extensions::api::system_display::DisplayUnitInfo* unit) = 0;
DISALLOW_COPY_AND_ASSIGN(DisplayInfoProvider);
};

Powered by Google App Engine
This is Rietveld 408576698