Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3074)

Unified Diff: chrome/browser/extensions/api/system_display/display_info_provider.cc

Issue 476103002: Make DisplayInfoProvider an interface (Closed) Base URL: git@github.com:tmpsantos/chromium.git@display_info
Patch Set: Fixed GN and Windows build Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/system_display/display_info_provider.cc
diff --git a/chrome/browser/extensions/api/system_display/display_info_provider.cc b/chrome/browser/extensions/api/system_display/display_info_provider.cc
index d57bd15ce0a477cb723337ed4af2b47f92c87ccf..1505e51e1a8927f6877204375fb50ba508abd919 100644
--- a/chrome/browser/extensions/api/system_display/display_info_provider.cc
+++ b/chrome/browser/extensions/api/system_display/display_info_provider.cc
@@ -2,9 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
James Cook 2014/08/15 19:58:42 Shouldn't this include display_info_provider.h?
-#include "chrome/browser/extensions/api/system_display/display_info_provider.h"
-
#include "base/strings/string_number_conversions.h"
+#include "chrome/browser/extensions/display_info_provider_impl.h"
#include "ui/gfx/display.h"
#include "ui/gfx/screen.h"
@@ -50,8 +49,6 @@ CreateDisplayUnitInfo(const gfx::Display& display, int64 primary_display_id) {
return unit;
}
-DisplayInfoProvider* g_display_info_provider = NULL;
-
} // namespace
@@ -59,18 +56,6 @@ DisplayInfoProvider::DisplayInfoProvider() {}
DisplayInfoProvider::~DisplayInfoProvider() {}
-DisplayInfoProvider* DisplayInfoProvider::Get() {
- if (g_display_info_provider == NULL)
- g_display_info_provider = new DisplayInfoProvider();
- return g_display_info_provider;
-}
-
-void DisplayInfoProvider::InitializeForTesting(
- DisplayInfoProvider* display_info_provider) {
- DCHECK(display_info_provider);
- g_display_info_provider = display_info_provider;
-}
-
DisplayInfo DisplayInfoProvider::GetAllDisplaysInfo() {
// TODO(scottmg): Native is wrong http://crbug.com/133312
gfx::Screen* screen = gfx::Screen::GetNativeScreen();

Powered by Google App Engine
This is Rietveld 408576698