Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 47603012: A fix for annoying clang error "unused-const-variabl" in third_party code. (Closed)

Created:
7 years, 1 month ago by tfarina
Modified:
7 years, 1 month ago
Reviewers:
epoger, Nico, bsalomon, mtklein
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

A fix for annoying clang error "unused-const-variabl" in third_party code. ../../third_party/externals/libwebp/src/enc/quant.c:105:23: error: unused variable 'kCoeffThresh' [-Werror,-Wunused-const-variable] static const uint16_t kCoeffThresh[16] = { ^ 1 error generated. BUG=None TEST=build with clang, ninja -C out/Debug most. R=bsalomon@google.com,epoger@google.com,thakis@chromium.org Committed: http://code.google.com/p/skia/source/detail?r=11990

Patch Set 1 #

Patch Set 2 : does NOT work - why? #

Total comments: 2

Patch Set 3 : without the exclamation mark #

Patch Set 4 : turn off warnings in libwebp_enc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gyp/libwebp.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
tfarina
I know this is not the right fix, but I put it here for review ...
7 years, 1 month ago (2013-10-28 18:03:41 UTC) #1
mtklein
On 2013/10/28 18:03:41, tfarina wrote: > I know this is not the right fix, but ...
7 years, 1 month ago (2013-10-28 18:20:15 UTC) #2
tfarina
My original approach, that doesn't work. Mike, please, review my patch set 2 and help ...
7 years, 1 month ago (2013-10-28 19:28:29 UTC) #3
tfarina
On 2013/10/28 18:20:15, mtklein wrote: > On 2013/10/28 18:03:41, tfarina wrote: > > I know ...
7 years, 1 month ago (2013-10-28 19:29:20 UTC) #4
mtklein
https://codereview.chromium.org/47603012/diff/70001/gyp/libwebp.gyp File gyp/libwebp.gyp (right): https://codereview.chromium.org/47603012/diff/70001/gyp/libwebp.gyp#newcode18 gyp/libwebp.gyp:18: 'cflags!': [ '-Wno-unused-const-variable', ], Try removing the "!"? That ...
7 years, 1 month ago (2013-10-28 19:37:36 UTC) #5
tfarina
https://codereview.chromium.org/47603012/diff/70001/gyp/libwebp.gyp File gyp/libwebp.gyp (right): https://codereview.chromium.org/47603012/diff/70001/gyp/libwebp.gyp#newcode18 gyp/libwebp.gyp:18: 'cflags!': [ '-Wno-unused-const-variable', ], On 2013/10/28 19:37:37, mtklein wrote: ...
7 years, 1 month ago (2013-10-28 19:49:11 UTC) #6
mtklein
On 2013/10/28 19:49:11, tfarina wrote: > https://codereview.chromium.org/47603012/diff/70001/gyp/libwebp.gyp > File gyp/libwebp.gyp (right): > > https://codereview.chromium.org/47603012/diff/70001/gyp/libwebp.gyp#newcode18 > ...
7 years, 1 month ago (2013-10-28 20:05:53 UTC) #7
tfarina
On 2013/10/28 20:05:53, mtklein wrote: > On 2013/10/28 19:49:11, tfarina wrote: > > https://codereview.chromium.org/47603012/diff/70001/gyp/libwebp.gyp > ...
7 years, 1 month ago (2013-10-28 21:16:53 UTC) #8
mtklein
On 2013/10/28 21:16:53, tfarina wrote: > On 2013/10/28 20:05:53, mtklein wrote: > > On 2013/10/28 ...
7 years, 1 month ago (2013-10-28 21:30:27 UTC) #9
tfarina
On 2013/10/28 21:30:27, mtklein wrote: > On 2013/10/28 21:16:53, tfarina wrote: > > On 2013/10/28 ...
7 years, 1 month ago (2013-10-28 21:40:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/47603012/190001
7 years, 1 month ago (2013-10-28 21:40:29 UTC) #11
Nico
(Is this gyp file used for anything? Can the warning be fixed, instead of suppressed?)
7 years, 1 month ago (2013-10-28 22:00:08 UTC) #12
mtklein
On 2013/10/28 22:00:08, Nico wrote: > (Is this gyp file used for anything? Can the ...
7 years, 1 month ago (2013-10-28 22:05:05 UTC) #13
commit-bot: I haz the power
7 years, 1 month ago (2013-10-28 22:05:17 UTC) #14
Message was sent while issue was closed.
Change committed as 11990

Powered by Google App Engine
This is Rietveld 408576698