Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Side by Side Diff: gyp/libwebp.gyp

Issue 47603012: A fix for annoying clang error "unused-const-variabl" in third_party code. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: does NOT work - why? Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'use_system_libwebp%': 0, 7 'use_system_libwebp%': 0,
8 }, 8 },
9 'conditions': [ 9 'conditions': [
10 ['use_system_libwebp==0', { 10 ['use_system_libwebp==0', {
11 'targets': [ 11 'targets': [
12 { 12 {
13 'target_name': 'libwebp_dec', 13 'target_name': 'libwebp_dec',
14 'type': 'static_library', 14 'type': 'static_library',
15 'include_dirs': [ 15 'include_dirs': [
16 '../third_party/externals/libwebp', 16 '../third_party/externals/libwebp',
17 ], 17 ],
18 'cflags!': [ '-Wno-unused-const-variable', ],
mtklein 2013/10/28 19:37:37 Try removing the "!"? That means "remove this", d
tfarina 2013/10/28 19:49:11 I tried both ways, with and without. It doesn't wo
18 'sources': [ 19 'sources': [
19 '../third_party/externals/libwebp/src/dec/alpha.c', 20 '../third_party/externals/libwebp/src/dec/alpha.c',
20 '../third_party/externals/libwebp/src/dec/buffer.c', 21 '../third_party/externals/libwebp/src/dec/buffer.c',
21 '../third_party/externals/libwebp/src/dec/frame.c', 22 '../third_party/externals/libwebp/src/dec/frame.c',
22 '../third_party/externals/libwebp/src/dec/idec.c', 23 '../third_party/externals/libwebp/src/dec/idec.c',
23 '../third_party/externals/libwebp/src/dec/io.c', 24 '../third_party/externals/libwebp/src/dec/io.c',
24 '../third_party/externals/libwebp/src/dec/layer.c', 25 '../third_party/externals/libwebp/src/dec/layer.c',
25 '../third_party/externals/libwebp/src/dec/quant.c', 26 '../third_party/externals/libwebp/src/dec/quant.c',
26 '../third_party/externals/libwebp/src/dec/tree.c', 27 '../third_party/externals/libwebp/src/dec/tree.c',
27 '../third_party/externals/libwebp/src/dec/vp8.c', 28 '../third_party/externals/libwebp/src/dec/vp8.c',
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 'link_settings': { 168 'link_settings': {
168 'libraries': [ 169 'libraries': [
169 '-lwebp', 170 '-lwebp',
170 ], 171 ],
171 }, 172 },
172 } 173 }
173 ], 174 ],
174 }], 175 }],
175 ], 176 ],
176 } 177 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698