Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Unified Diff: chrome/browser/extensions/extension_test_notification_observer.cc

Issue 475813004: Clean up NOTIFICATION_EXTENSION_PAGE_ACTION_[ COUNT | VISIBILITY ]_CHANGED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mac Compile Fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_test_notification_observer.cc
diff --git a/chrome/browser/extensions/extension_test_notification_observer.cc b/chrome/browser/extensions/extension_test_notification_observer.cc
index 665cd5285d3936612c126c5139eedc1699d24b43..162d42190734f06ad9e9fc4bb385e4b7637026aa 100644
--- a/chrome/browser/extensions/extension_test_notification_observer.cc
+++ b/chrome/browser/extensions/extension_test_notification_observer.cc
@@ -21,12 +21,6 @@ using extensions::Extension;
namespace {
-bool HasExtensionPageActionCountReachedTarget(LocationBarTesting* location_bar,
- int target_page_action_count) {
- VLOG(1) << "Number of page actions: " << location_bar->PageActionCount();
- return location_bar->PageActionCount() == target_page_action_count;
-}
-
bool HasExtensionPageActionVisibilityReachedTarget(
LocationBarTesting* location_bar,
int target_visible_page_action_count) {
@@ -149,17 +143,6 @@ void ExtensionTestNotificationObserver::WaitForNotification(
notification_type, content::NotificationService::AllSources()).Wait();
}
-bool ExtensionTestNotificationObserver::WaitForPageActionCountChangeTo(
- int count) {
- LocationBarTesting* location_bar =
- browser_->window()->GetLocationBar()->GetLocationBarForTesting();
- WaitForCondition(
- base::Bind(
- &HasExtensionPageActionCountReachedTarget, location_bar, count),
- extensions::NOTIFICATION_EXTENSION_PAGE_ACTION_COUNT_CHANGED);
- return true;
-}
-
bool ExtensionTestNotificationObserver::WaitForPageActionVisibilityChangeTo(
int count) {
LocationBarTesting* location_bar =
@@ -167,7 +150,7 @@ bool ExtensionTestNotificationObserver::WaitForPageActionVisibilityChangeTo(
WaitForCondition(
base::Bind(
&HasExtensionPageActionVisibilityReachedTarget, location_bar, count),
- extensions::NOTIFICATION_EXTENSION_PAGE_ACTION_VISIBILITY_CHANGED);
+ extensions::NOTIFICATION_EXTENSION_PAGE_ACTIONS_UPDATED);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698