chrome/browser/extensions/lazy_background_page_apitest.cc - Issue 475813004: Clean up NOTIFICATION_EXTENSION_PAGE_ACTION_[ COUNT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/lazy_background_page_apitest.cc

Issue 475813004: Clean up NOTIFICATION_EXTENSION_PAGE_ACTION_[ COUNT | VISIBILITY ]_CHANGED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac Compile Fix Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_test_notification_observer.cc ('k') | chrome/browser/extensions/location_bar_controller.cc » ('j') | chrome/browser/extensions/location_bar_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/lazy_background_page_apitest.cc

diff --git a/chrome/browser/extensions/lazy_background_page_apitest.cc b/chrome/browser/extensions/lazy_background_page_apitest.cc

index 95c0452aa4eee73f034020959c949097359106d3..9a0f863abbfb004f31e6b6040b5d17dc5b2311ff 100644

--- a/chrome/browser/extensions/lazy_background_page_apitest.cc

+++ b/chrome/browser/extensions/lazy_background_page_apitest.cc

@@ -173,7 +173,7 @@ IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest, BroadcastEvent) {

// Open a tab to a URL that will trigger the page action to show.

LazyBackgroundObserver page_complete;

content::WindowedNotificationObserver page_action_changed(

- extensions::NOTIFICATION_EXTENSION_PAGE_ACTION_VISIBILITY_CHANGED,

+ extensions::NOTIFICATION_EXTENSION_PAGE_ACTIONS_UPDATED,

content::NotificationService::AllSources());

ui_test_utils::NavigateToURL(

browser(), embedded_test_server()->GetURL("/extensions/test_file.html"));