chrome/browser/resources/extensions/chromeos/kiosk_apps.js - Issue 475633006: Typecheck JS files for chrome://extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/chromeos/kiosk_apps.js

Issue 475633006: Typecheck JS files for chrome://extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@D_asserts_codingconvention

Patch Set: looked twice Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/extensions/chromeos/kiosk_app_list.js ('k') | chrome/browser/resources/extensions/compiled_resources.gyp » ('j') | chrome/browser/resources/extensions/extension_code.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/extensions/chromeos/kiosk_apps.js

diff --git a/chrome/browser/resources/extensions/chromeos/kiosk_apps.js b/chrome/browser/resources/extensions/chromeos/kiosk_apps.js

index 80effaf87d473e3931aaa53a47ebfdc459b2bd11..e378a3e9c58cc0ee8c8df01b4f94e6fd41f67dc8 100644

--- a/chrome/browser/resources/extensions/chromeos/kiosk_apps.js

+++ b/chrome/browser/resources/extensions/chromeos/kiosk_apps.js

@@ -100,8 +100,9 @@ cr.define('extensions', function() {

/**

* Sets apps to be displayed in kiosk-app-list.

- * @param {!Object.<{apps: !Array.<Object>, disableBailout: boolean}>}

- * settings An object containing an array of app info objects and

+ * @param {!Object.<{apps: !Array.<BackendAppDataObject>,

+ * disableBailout: boolean, hasAutoLaunchApp: boolean}>} settings

+ * An object containing an array of app info objects and

* disable bailout shortcut flag.

KioskAppsOverlay.setSettings = function(settings) {

@@ -128,7 +129,7 @@ cr.define('extensions', function() {

/**

* Enables consumer kiosk.

- * @param {!boolean} enable True if consumer kiosk feature is enabled.

+ * @param {!{kioskEnabled: boolean, autoLaunchEnabled: boolean}} params

KioskAppsOverlay.enableKiosk = function(params) {

$('add-kiosk-app').hidden = !params.kioskEnabled;