Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2391)

Unified Diff: chrome/browser/resources/extensions/extension_code.js

Issue 475633006: Typecheck JS files for chrome://extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@D_asserts_codingconvention
Patch Set: looked twice Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extension_code.js
diff --git a/chrome/browser/resources/extensions/extension_code.js b/chrome/browser/resources/extensions/extension_code.js
index c22376b834dfb5f709087e369c918664e917c56f..c63b4edd381feb1f4c8d247a7e63360edd6a976f 100644
--- a/chrome/browser/resources/extensions/extension_code.js
+++ b/chrome/browser/resources/extensions/extension_code.js
@@ -2,12 +2,22 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+/**
+ * @typedef {{afterHighlight: string,
+ * beforeHighlight: string,
+ * highlight:string,
Dan Beam 2014/08/21 18:27:47 space after :
Vitaly Pavlenko 2014/08/22 01:43:39 Done.
+ * title: string}}
+ */
+var ExtensionCodeObject;
Dan Beam 2014/08/21 18:27:47 ExtensionHighlight
Vitaly Pavlenko 2014/08/22 01:43:39 Done.
+
cr.define('extensions', function() {
'use strict';
/**
* ExtensionCode is an element which displays code in a styled div, and is
* designed to highlight errors.
+ * @constructor
+ * @extends {HTMLDivElement}
*/
function ExtensionCode(div) {
div.__proto__ = ExtensionCode.prototype;
@@ -20,11 +30,10 @@ cr.define('extensions', function() {
/**
* Populate the content area of the code div with the given code. This will
* highlight the erroneous section (if any).
- * @param {Object} code An object with four strings: beforeHighlight,
- * afterHighlight, highlight, and the message. The 'highlight' strings
+ * @param {ExtensionCodeObject} code The 'highlight' strings
Dan Beam 2014/08/21 18:27:47 wrap better
Vitaly Pavlenko 2014/08/22 01:43:39 Done.
* represent the three portions of the file's content to display - the
* portion which is most relevant and should be emphasized (highlight),
- * and the parts both before and after this portion. The message is the
+ * and the parts both before and after this portion. The title is the
* error message, which will be the mouseover hint for the highlighted
* region. These may be empty.
* @param {string} emptyMessage The message to display if the code

Powered by Google App Engine
This is Rietveld 408576698