chrome/browser/resources/extensions/extension_options_overlay.html - Issue 475543003: Display extension options in a WebUI overlay instead of in a new tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extension_options_overlay.html

Issue 475543003: Display extension options in a WebUI overlay instead of in a new tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Diff from getCurrent CL again Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/extensions/extension_list.js ('k') | chrome/browser/resources/extensions/extension_options_overlay.js » ('j') | chrome/browser/resources/extensions/extension_options_overlay.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/extensions/extension_options_overlay.html

diff --git a/chrome/browser/resources/extensions/extension_options_overlay.html b/chrome/browser/resources/extensions/extension_options_overlay.html

new file mode 100644

index 0000000000000000000000000000000000000000..8b0bef866305e553101f0d3c8d35d88a46f238d9

--- /dev/null

+++ b/chrome/browser/resources/extensions/extension_options_overlay.html

@@ -0,0 +1,10 @@

+<!--

+Use of this source code is governed by a BSD-style license that can be found

+in the LICENSE file.

+-->

+<div id="extension-options-overlay" class="page">

+ <div class="close-button"></div>

+ <h1 id="extension-options-overlay-title"></h1>

+ <div class="extension-options-overlay-guest"></div>

Devlin 2014/08/15 15:19:51 Will we have more than one of these?

not at google - send to devlin 2014/08/15 15:51:06 I don't think it hurts to have this a class, and t

+</div>