chrome/browser/resources/extensions/extension_options_overlay.html - Issue 475543003: Display extension options in a WebUI overlay instead of in a new tab

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/extensions/extension_options_overlay.html

Issue 475543003: Display extension options in a WebUI overlay instead of in a new tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Diff from getCurrent CL again Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/extensions/extension_list.js ('k') | chrome/browser/resources/extensions/extension_options_overlay.js » ('j') | chrome/browser/resources/extensions/extension_options_overlay.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!--

	2 Copyright 2014 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be found

	4 in the LICENSE file.

	5 -->

	6 <div id="extension-options-overlay" class="page">

	7 <div class="close-button"></div>

	8 <h1 id="extension-options-overlay-title"></h1>

	9 <div class="extension-options-overlay-guest"></div>
	Devlin 2014/08/15 15:19:51 Will we have more than one of these? Will we have more than one of these? not at google - send to devlin 2014/08/15 15:51:06 I don't think it hurts to have this a class, and t Show quoted text On 2014/08/15 15:19:51, Devlin wrote: > Will we have more than one of these? I don't think it hurts to have this a class, and the name implies generic-ness.
	10 </div>

OLD	NEW