Issue 475373002: ASSERT(!m_referencedNodes.size()) in AudioContext's destructor should be enabled in oilpan builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 475373002: ASSERT(!m_referencedNodes.size()) in AudioContext's destructor should be enabled in oilpan builds (Closed)

Created:
6 years, 4 months ago by haraken

Modified:
6 years, 4 months ago

Reviewers:
oilpan-reviews, tkent

CC:
blink-reviews, Raymond Toy

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

ASSERT(!m_referencedNodes.size()) in AudioContext's destructor should be enabled in oilpan builds Given that we clear the m_referencedNodes in AudioContext::uninitialize(), the m_referencedNodes should be empty in both oilpan builds and non-oilpan builds. BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180423

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/modules/webaudio/AudioContext.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/475373002/1

6 years, 4 months ago (2014-08-18 04:10:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 180423

Expand Messages | Collapse Messages