Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Side by Side Diff: Source/modules/webaudio/AudioContext.cpp

Issue 475373002: ASSERT(!m_referencedNodes.size()) in AudioContext's destructor should be enabled in oilpan builds (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, Google Inc. All rights reserved. 2 * Copyright (C) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 158
159 AudioContext::~AudioContext() 159 AudioContext::~AudioContext()
160 { 160 {
161 #if DEBUG_AUDIONODE_REFERENCES 161 #if DEBUG_AUDIONODE_REFERENCES
162 fprintf(stderr, "%p: AudioContext::~AudioContext()\n", this); 162 fprintf(stderr, "%p: AudioContext::~AudioContext()\n", this);
163 #endif 163 #endif
164 // AudioNodes keep a reference to their context, so there should be no way t o be in the destructor if there are still AudioNodes around. 164 // AudioNodes keep a reference to their context, so there should be no way t o be in the destructor if there are still AudioNodes around.
165 ASSERT(!m_isInitialized); 165 ASSERT(!m_isInitialized);
166 #if !ENABLE(OILPAN) 166 #if !ENABLE(OILPAN)
167 ASSERT(!m_nodesToDelete.size()); 167 ASSERT(!m_nodesToDelete.size());
168 #endif
168 ASSERT(!m_referencedNodes.size()); 169 ASSERT(!m_referencedNodes.size());
169 #endif
170 ASSERT(!m_finishedNodes.size()); 170 ASSERT(!m_finishedNodes.size());
171 ASSERT(!m_automaticPullNodes.size()); 171 ASSERT(!m_automaticPullNodes.size());
172 if (m_automaticPullNodesNeedUpdating) 172 if (m_automaticPullNodesNeedUpdating)
173 m_renderingAutomaticPullNodes.resize(m_automaticPullNodes.size()); 173 m_renderingAutomaticPullNodes.resize(m_automaticPullNodes.size());
174 ASSERT(!m_renderingAutomaticPullNodes.size()); 174 ASSERT(!m_renderingAutomaticPullNodes.size());
175 } 175 }
176 176
177 void AudioContext::initialize() 177 void AudioContext::initialize()
178 { 178 {
179 if (isInitialized()) 179 if (isInitialized())
(...skipping 827 matching lines...) Expand 10 before | Expand all | Expand 10 after
1007 visitor->trace(m_referencedNodes); 1007 visitor->trace(m_referencedNodes);
1008 visitor->trace(m_liveNodes); 1008 visitor->trace(m_liveNodes);
1009 visitor->trace(m_liveAudioSummingJunctions); 1009 visitor->trace(m_liveAudioSummingJunctions);
1010 #endif 1010 #endif
1011 EventTargetWithInlineData::trace(visitor); 1011 EventTargetWithInlineData::trace(visitor);
1012 } 1012 }
1013 1013
1014 } // namespace blink 1014 } // namespace blink
1015 1015
1016 #endif // ENABLE(WEB_AUDIO) 1016 #endif // ENABLE(WEB_AUDIO)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698