third_party/harfbuzz-ng/src/hb-graphite2.cc - Issue 475363002: Roll HarfBuzz to 0.9.35

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/harfbuzz-ng/src/hb-graphite2.cc

Issue 475363002: Roll HarfBuzz to 0.9.35 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Windows build fix attempt Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/harfbuzz-ng/src/hb-graphite2.cc

diff --git a/third_party/harfbuzz-ng/src/hb-graphite2.cc b/third_party/harfbuzz-ng/src/hb-graphite2.cc

index 709aa94419c347a7dbe537523b64bd35edd6be12..807c3308771162d3e021fbca12b59fd506bb1ae3 100644

--- a/third_party/harfbuzz-ng/src/hb-graphite2.cc

+++ b/third_party/harfbuzz-ng/src/hb-graphite2.cc

@@ -274,8 +274,8 @@ _hb_graphite2_shape (hb_shape_plan_t *shape_plan,

while ((DIV_CEIL (sizeof (hb_graphite2_cluster_t) * buffer->len, sizeof (*scratch)) +

DIV_CEIL (sizeof (hb_codepoint_t) * glyph_count, sizeof (*scratch))) > scratch_size)

{

- buffer->ensure (buffer->allocated * 2);

- if (unlikely (buffer->in_error)) {

+ if (unlikely (!buffer->ensure (buffer->allocated * 2)))

+ {

if (feats) gr_featureval_destroy (feats);

gr_seg_destroy (seg);

return false;