Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 475303002: Reduce code duplication for parsing clip-path/filter (Closed)

Created:
6 years, 4 months ago by Timothy Loh
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Reduce code duplication for parsing clip-path/filter The parsing logic for clip-path and filter is identical to that for marker-start, etc. BUG=404023 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180346

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M Source/core/css/parser/CSSPropertyParser.cpp View 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Timothy Loh
6 years, 4 months ago (2014-08-15 02:07:24 UTC) #1
Erik Dahlström (inactive)
Non-owner LGTM.
6 years, 4 months ago (2014-08-15 08:21:51 UTC) #2
rune
lgtm
6 years, 4 months ago (2014-08-15 08:24:56 UTC) #3
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 4 months ago (2014-08-15 08:28:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/475303002/1
6 years, 4 months ago (2014-08-15 08:29:25 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-15 09:29:31 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 10:03:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (1) as 180346

Powered by Google App Engine
This is Rietveld 408576698