Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 475303002: Reduce code duplication for parsing clip-path/filter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp
index 81f39eeb9d516d0674b378673fb105cdf2c220d9..4e596661cac1daf977b4153b0ee52135a04f1840 100644
--- a/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/Source/core/css/parser/CSSPropertyParser.cpp
@@ -8229,6 +8229,8 @@ bool CSSPropertyParser::parseSVGValue(CSSPropertyID propId, bool important)
validPrimitive = true;
break;
+ case CSSPropertyClipPath:
+ case CSSPropertyFilter:
case CSSPropertyMarkerStart:
case CSSPropertyMarkerMid:
case CSSPropertyMarkerEnd:
@@ -8396,19 +8398,8 @@ bool CSSPropertyParser::parseSVGValue(CSSPropertyID propId, bool important)
validPrimitive = true;
else
parsedValue = parseSVGStrokeDasharray();
-
break;
- case CSSPropertyClipPath: // <uri> | none | inherit
- case CSSPropertyFilter:
- if (id == CSSValueNone) {
- validPrimitive = true;
- } else if (value->unit == CSSPrimitiveValue::CSS_URI) {
- parsedValue = CSSPrimitiveValue::create(value->string, (CSSPrimitiveValue::UnitType) value->unit);
- if (parsedValue)
- m_valueList->next();
- }
- break;
case CSSPropertyMaskType: // luminance | alpha | inherit
if (id == CSSValueLuminance || id == CSSValueAlpha)
validPrimitive = true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698