Mojo: Add embedder::PlatformSupport and a simple implementation (and a bit of plumbing).

Mojo: Add embedder::PlatformSupport and a simple implementation (and a bit of plumbing).

R=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289878

[darin (slow to review), 2014-08-14 23:30:57]

LGTM

https://codereview.chromium.org/475223002/diff/1/mojo/embedder/platform_suppo...
File mojo/embedder/platform_support.h (right):

https://codereview.chromium.org/475223002/diff/1/mojo/embedder/platform_suppo...
mojo/embedder/platform_support.h:23: virtual ~PlatformSupport() {}
should this destructor be protected as well? based on what you have so far in
this CL, it looks like the system will not take ownership over this pointer,
right?

[viettrungluu, 2014-08-15 00:25:28]

https://codereview.chromium.org/475223002/diff/1/mojo/embedder/platform_suppo...
File mojo/embedder/platform_support.h (right):

https://codereview.chromium.org/475223002/diff/1/mojo/embedder/platform_suppo...
mojo/embedder/platform_support.h:23: virtual ~PlatformSupport() {}
On 2014/08/14 23:30:57, darin wrote:
> should this destructor be protected as well? based on what you have so far in
> this CL, it looks like the system will not take ownership over this pointer,
> right?

Probably when I add one to Core, I'll make Core own it (to avoid having to say
that the caller must ensure that the PlatformSupport outlives Core, etc.).

(At least that's my current thinking. I'm not sure if it's entirely right.)

[viettrungluu, 2014-08-15 01:42:37]

The CQ bit was checked by viettrungluu@chromium.org

[commit-bot: I haz the power, 2014-08-15 01:43:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/475223002/1

[darin (slow to review), 2014-08-15 01:59:56]

OK


On Thu, Aug 14, 2014 at 5:25 PM, <viettrungluu@chromium.org> wrote:

>
> https://codereview.chromium.org/475223002/diff/1/mojo/
> embedder/platform_support.h
> File mojo/embedder/platform_support.h (right):
>
> https://codereview.chromium.org/475223002/diff/1/mojo/
> embedder/platform_support.h#newcode23
> mojo/embedder/platform_support.h:23: virtual ~PlatformSupport() {}
> On 2014/08/14 23:30:57, darin wrote:
>
>> should this destructor be protected as well? based on what you have so
>>
> far in
>
>> this CL, it looks like the system will not take ownership over this
>>
> pointer,
>
>> right?
>>
>
> Probably when I add one to Core, I'll make Core own it (to avoid having
> to say that the caller must ensure that the PlatformSupport outlives
> Core, etc.).
>
> (At least that's my current thinking. I'm not sure if it's entirely
> right.)
>
> https://codereview.chromium.org/475223002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-08-15 15:50:38]

Committed patchset #1 (1) as 289878