Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Unified Diff: mojo/system/shared_buffer_dispatcher.cc

Issue 475223002: Mojo: Add embedder::PlatformSupport and a simple implementation (and a bit of plumbing). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/system/shared_buffer_dispatcher.cc
diff --git a/mojo/system/shared_buffer_dispatcher.cc b/mojo/system/shared_buffer_dispatcher.cc
index fd879097ebcfb864f25cf959de5c5898698b5d13..fc1a66413b8f13cb18684e0b40d3694f4368d6b6 100644
--- a/mojo/system/shared_buffer_dispatcher.cc
+++ b/mojo/system/shared_buffer_dispatcher.cc
@@ -8,7 +8,8 @@
#include "base/logging.h"
#include "base/memory/scoped_ptr.h"
-#include "mojo/embedder/simple_platform_shared_buffer.h"
+#include "mojo/embedder/platform_support.h"
+#include "mojo/embedder/simple_platform_shared_buffer.h" // TODO(vtl): Remove.
#include "mojo/public/c/system/macros.h"
#include "mojo/system/constants.h"
#include "mojo/system/memory.h"
@@ -62,6 +63,7 @@ MojoResult SharedBufferDispatcher::ValidateCreateOptions(
// static
MojoResult SharedBufferDispatcher::Create(
+ embedder::PlatformSupport* platform_support,
const MojoCreateSharedBufferOptions& /*validated_options*/,
uint64_t num_bytes,
scoped_refptr<SharedBufferDispatcher>* result) {
@@ -70,10 +72,8 @@ MojoResult SharedBufferDispatcher::Create(
if (num_bytes > kMaxSharedMemoryNumBytes)
return MOJO_RESULT_RESOURCE_EXHAUSTED;
- // TODO(vtl): Call out to "platform support" for this.
scoped_refptr<embedder::PlatformSharedBuffer> shared_buffer(
- embedder::SimplePlatformSharedBuffer::Create(
- static_cast<size_t>(num_bytes)));
+ platform_support->CreateSharedBuffer(static_cast<size_t>(num_bytes)));
if (!shared_buffer)
return MOJO_RESULT_RESOURCE_EXHAUSTED;
@@ -121,6 +121,9 @@ scoped_refptr<SharedBufferDispatcher> SharedBufferDispatcher::Deserialize(
// Wrapping |platform_handle| in a |ScopedPlatformHandle| means that it'll be
// closed even if creation fails.
+ // TODO(vtl): This is obviously wrong -- but we need to have a
+ // |PlatformSupport| plumbed through (probably via the |Channel|), and use its
+ // |CreateSharedBufferFromHandle()|.
scoped_refptr<embedder::PlatformSharedBuffer> shared_buffer(
embedder::SimplePlatformSharedBuffer::CreateFromPlatformHandle(
num_bytes, embedder::ScopedPlatformHandle(platform_handle)));

Powered by Google App Engine
This is Rietveld 408576698