Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 475153002: gn: Add missing NDEBUG define in Release (Closed)

Created:
6 years, 4 months ago by scottmg
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

gn: Add missing NDEBUG define in Release This is required at least on Windows as it's used by system headers to control things like assert, etc. R=brettw@chromium.org BUG=335824, 354261 Committed: https://crrev.com/4d2ee242cdc6eb2ce8119802b7c51f8393c945f0 Cr-Commit-Position: refs/heads/master@{#293788}

Patch Set 1 #

Patch Set 2 : maybe fix android? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M build/config/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/libphonenumber/BUILD.gn View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (1 generated)
scottmg
6 years, 4 months ago (2014-08-14 20:06:09 UTC) #1
brettw
lgtm
6 years, 4 months ago (2014-08-14 22:54:05 UTC) #2
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 4 months ago (2014-08-14 22:56:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/475153002/1
6 years, 4 months ago (2014-08-14 23:00:39 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-15 05:04:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 05:16:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/6072)
6 years, 4 months ago (2014-08-15 05:16:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/475153002/20001
6 years, 3 months ago (2014-09-08 20:11:11 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 30126e08ea8b2c31496a3f472593de971a8d806a
6 years, 3 months ago (2014-09-08 21:34:24 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:48:15 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4d2ee242cdc6eb2ce8119802b7c51f8393c945f0
Cr-Commit-Position: refs/heads/master@{#293788}

Powered by Google App Engine
This is Rietveld 408576698