Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: third_party/libphonenumber/BUILD.gn

Issue 475153002: gn: Add missing NDEBUG define in Release (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: maybe fix android? Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libphonenumber/BUILD.gn
diff --git a/third_party/libphonenumber/BUILD.gn b/third_party/libphonenumber/BUILD.gn
index 994eb3438ea688e72f04c54c4ff383b1847aad6c..26386a64bac43d21758c8778577920d146621ed8 100644
--- a/third_party/libphonenumber/BUILD.gn
+++ b/third_party/libphonenumber/BUILD.gn
@@ -44,6 +44,11 @@ static_library("libphonenumber_without_metadata") {
"src/phonenumbers/utf/unilib.cc",
]
+ # TODO(scottmg): Temporary until https://codereview.appspot.com/134650043/
+ # lands and rolls. http://crbug.com/335824
+ configs -= [ "//build/config/compiler:chromium_code" ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
+
direct_dependent_configs = [ ":libphonenumber_config" ]
deps = [
« no previous file with comments | « build/config/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698