Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 475113005: Refactoring: Create per-connection packet writers in QuicDispatcher. (Closed)

Created:
6 years, 4 months ago by wtc
Modified:
6 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng
Project:
chromium
Visibility:
Public.

Description

Refactoring: Create per-connection packet writers in QuicDispatcher. To make porting the QUIC EndToEndTest to Chromium possible with fewer Chromium-specific parts in shared code, I've made QuicDispatcher expose and accept a QuicDispatcher::PacketWriterFactory which it uses to create a new packet writer wrapper for every QuicConnection. I also changed QuicConnection to accept a QuicConnection::PacketWriterFactory (a second new type of factory) rather than the writer itself in its constructor, since the per-connection packet writers need to be created with the connection already existing. Merge internal CL: 73064412 Written by Daniel Ziegler <dmziegler@chromium.org>; Original review URL: https://codereview.chromium.org/467963002/ R=rch@chromium.org,wtc@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291314

Patch Set 1 #

Patch Set 2 : Patch set 4 from Daniel's CL #

Patch Set 3 : Additional cleanups #

Patch Set 4 : Rebase #

Patch Set 5 : Add new files to net/BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+702 lines, -185 lines) Patch
M net/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M net/net.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_blocked_writer_interface.h View 1 1 chunk +14 lines, -0 lines 0 comments Download
M net/quic/quic_client_session.h View 1 2 3 3 chunks +0 lines, -3 lines 0 comments Download
M net/quic/quic_client_session.cc View 1 2 3 3 chunks +0 lines, -3 lines 0 comments Download
M net/quic/quic_client_session_test.cc View 1 2 3 3 chunks +2 lines, -35 lines 0 comments Download
M net/quic/quic_connection.h View 1 chunk +12 lines, -4 lines 0 comments Download
M net/quic/quic_connection.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 2 3 8 chunks +26 lines, -12 lines 0 comments Download
M net/quic/quic_dispatcher.h View 1 5 chunks +54 lines, -16 lines 0 comments Download
M net/quic/quic_dispatcher.cc View 1 2 4 chunks +32 lines, -22 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 2 3 5 chunks +20 lines, -7 lines 0 comments Download
M net/quic/quic_per_connection_packet_writer.h View 1 2 3 chunks +9 lines, -11 lines 0 comments Download
M net/quic/quic_per_connection_packet_writer.cc View 1 2 2 chunks +13 lines, -7 lines 0 comments Download
M net/quic/quic_server.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_server_session.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M net/quic/quic_server_session.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/quic_server_test.cc View 1 chunk +4 lines, -1 line 0 comments Download
M net/quic/quic_stream_factory.cc View 1 2 3 4 chunks +24 lines, -6 lines 0 comments Download
M net/quic/test_tools/mock_quic_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/mock_quic_dispatcher.cc View 1 chunk +6 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 2 3 2 chunks +42 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 2 5 chunks +73 lines, -8 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 2 3 5 chunks +15 lines, -5 lines 0 comments Download
M net/tools/quic/quic_client.h View 1 1 chunk +12 lines, -0 lines 0 comments Download
M net/tools/quic/quic_client.cc View 2 chunks +18 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 1 4 chunks +53 lines, -15 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 3 chunks +26 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 3 chunks +8 lines, -6 lines 0 comments Download
A net/tools/quic/quic_per_connection_packet_writer.h View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
A net/tools/quic/quic_per_connection_packet_writer.cc View 1 1 chunk +46 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_server_test.cc View 1 chunk +4 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/mock_quic_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/test_tools/mock_quic_dispatcher.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_dispatcher_peer.h View 1 chunk +5 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_dispatcher_peer.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 1 2 chunks +42 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.cc View 1 2 5 chunks +73 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wtc
Ryan, This is a clone of Daniel's CL. Patch set 1 is essentially the original ...
6 years, 4 months ago (2014-08-21 01:07:46 UTC) #1
Ryan Hamilton
lgtm
6 years, 4 months ago (2014-08-21 22:16:22 UTC) #2
wtc
The CQ bit was checked by wtc@chromium.org
6 years, 4 months ago (2014-08-21 23:56:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/475113005/80001
6 years, 4 months ago (2014-08-21 23:59:35 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 01:58:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 (80001) as 291314

Powered by Google App Engine
This is Rietveld 408576698