Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1545)

Unified Diff: net/quic/quic_client_session_test.cc

Issue 475113005: Refactoring: Create per-connection packet writers in QuicDispatcher. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add new files to net/BUILD.gn Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_client_session.cc ('k') | net/quic/quic_connection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_client_session_test.cc
diff --git a/net/quic/quic_client_session_test.cc b/net/quic/quic_client_session_test.cc
index 1e13e89ae49920f850a9c7dd36ef582b227375a8..39b2ae5a2c0537b585e480b9d42eeb5691989eae 100644
--- a/net/quic/quic_client_session_test.cc
+++ b/net/quic/quic_client_session_test.cc
@@ -20,7 +20,6 @@
#include "net/quic/crypto/quic_decrypter.h"
#include "net/quic/crypto/quic_encrypter.h"
#include "net/quic/crypto/quic_server_info.h"
-#include "net/quic/quic_default_packet_writer.h"
#include "net/quic/test_tools/crypto_test_utils.h"
#include "net/quic/test_tools/quic_client_session_peer.h"
#include "net/quic/test_tools/quic_test_utils.h"
@@ -39,43 +38,12 @@ namespace {
const char kServerHostname[] = "www.example.org";
const uint16 kServerPort = 80;
-class TestPacketWriter : public QuicDefaultPacketWriter {
- public:
- TestPacketWriter(QuicVersion version) : version_(version) {}
-
- // QuicPacketWriter
- virtual WriteResult WritePacket(
- const char* buffer, size_t buf_len,
- const IPAddressNumber& self_address,
- const IPEndPoint& peer_address) OVERRIDE {
- SimpleQuicFramer framer(SupportedVersions(version_));
- QuicEncryptedPacket packet(buffer, buf_len);
- EXPECT_TRUE(framer.ProcessPacket(packet));
- header_ = framer.header();
- return WriteResult(WRITE_STATUS_OK, packet.length());
- }
-
- virtual bool IsWriteBlockedDataBuffered() const OVERRIDE {
- // Chrome sockets' Write() methods buffer the data until the Write is
- // permitted.
- return true;
- }
-
- // Returns the header from the last packet written.
- const QuicPacketHeader& header() { return header_; }
-
- private:
- QuicVersion version_;
- QuicPacketHeader header_;
-};
-
class QuicClientSessionTest : public ::testing::TestWithParam<QuicVersion> {
protected:
QuicClientSessionTest()
- : writer_(new TestPacketWriter(GetParam())),
- connection_(
+ : connection_(
new PacketSavingConnection(false, SupportedVersions(GetParam()))),
- session_(connection_, GetSocket().Pass(), writer_.Pass(), NULL, NULL,
+ session_(connection_, GetSocket().Pass(), NULL, NULL,
&transport_security_state_,
make_scoped_ptr((QuicServerInfo*)NULL),
QuicServerId(kServerHostname, kServerPort, false,
@@ -107,7 +75,6 @@ class QuicClientSessionTest : public ::testing::TestWithParam<QuicVersion> {
ASSERT_EQ(OK, callback_.WaitForResult());
}
- scoped_ptr<QuicDefaultPacketWriter> writer_;
PacketSavingConnection* connection_;
CapturingNetLog net_log_;
MockClientSocketFactory socket_factory_;
« no previous file with comments | « net/quic/quic_client_session.cc ('k') | net/quic/quic_connection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698