Issue 474983007: fix numerical overflows in 565 blends

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 474983007: fix numerical overflows in 565 blends (Closed)

Created:
6 years, 4 months ago by reed1

Modified:
6 years, 4 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

fix numerical overflows in 565 blends BUG=skia:2797 Committed: https://skia.googlesource.com/skia/+/233c295980d54347ca1eda9095cd54b63a0268ec

Patch Set 1 #

Patch Set 2 : remove workaround from nanobench #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -13 lines)			Patch
	M	bench/nanobench.cpp	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
	M	src/core/SkBlitRow_D16.cpp	View	1	1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

reed1

These GMs change (acceptably) so they'll need to be suppressed/rebaselined gpusamplerstress_565 shadertext3_565 pictures_565 gradtext_565 gradients_view_perspective_565 ...

6 years, 4 months ago (2014-08-21 21:38:50 UTC) #3

mtklein

On 2014/08/21 21:38:50, reed1 wrote: > These GMs change (acceptably) so they'll need to be ...

6 years, 4 months ago (2014-08-21 22:40:24 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/474983007/20001

6 years, 4 months ago (2014-08-22 14:18:13 UTC) #6

commit-bot: I haz the power

6 years, 4 months ago (2014-08-22 14:27:20 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (20001) as 233c295980d54347ca1eda9095cd54b63a0268ec

Expand Messages | Collapse Messages