Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2403)

Unified Diff: bench/nanobench.cpp

Issue 474983007: fix numerical overflows in 565 blends (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: remove workaround from nanobench Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkBlitRow_D16.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bench/nanobench.cpp
diff --git a/bench/nanobench.cpp b/bench/nanobench.cpp
index 6968d6dac21deb835f11063a4731b3077673398e..ac49e843807e93efd8986b0b2ffe50b599201279 100644
--- a/bench/nanobench.cpp
+++ b/bench/nanobench.cpp
@@ -595,14 +595,6 @@ int nanobench_main() {
SkCanvas* canvas = targets[j]->surface.get() ? targets[j]->surface->getCanvas() : NULL;
const char* config = targets[j]->config.name;
-#ifdef SK_DEBUG
- // skia:2797 Some SKPs SkASSERT in debug mode. Skip them for now.
- if (0 == strcmp("565", config) && SkStrContains(bench->getName(), ".skp")) {
- SkDebugf("Skipping 565 %s. See skia:2797\n", bench->getName());
- continue;
- }
-#endif
-
const int loops =
#if SK_SUPPORT_GPU
Benchmark::kGPU_Backend == targets[j]->config.backend
« no previous file with comments | « no previous file | src/core/SkBlitRow_D16.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698