Issue 474913003: WakeLock API: IPC at browser side.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 474913003: WakeLock API: IPC at browser side.

Created:
6 years, 4 months ago by redchenko

Modified:
6 years, 3 months ago

Reviewers:
mlamouri (slow - plz ping)

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

WakeLock API: IPC at browser side. BUG=257511

Patch Set 1 #

Total comments: 2

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+119 lines, -0 lines)			Patch
A	content/browser/wake_lock/wake_lock_dispatcher_host.h	View	1 chunk	+39 lines, -0 lines	1 comment	Download
A	content/browser/wake_lock/wake_lock_dispatcher_host.cc	View	1 chunk	+71 lines, -0 lines	1 comment	Download
M	content/browser/web_contents/web_contents_impl.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	content/content_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

mlamouri (slow - plz ping)

6 years, 3 months ago (2014-09-03 13:20:57 UTC) #1

The plumbing looks okay but I guess this is not ready to land, right?

https://codereview.chromium.org/474913003/diff/1/content/browser/wake_lock/wa...
File content/browser/wake_lock/wake_lock_dispatcher_host.cc (right):

https://codereview.chromium.org/474913003/diff/1/content/browser/wake_lock/wa...
content/browser/wake_lock/wake_lock_dispatcher_host.cc:61: const int routed_id =
host->GetRoutingID();
If you use the routing id, shouldn't you use ::OnMessageReceived(const
IPC::Message&, RenderFrameHost*), then you can use
render_frame_host->GetRoutingID(). I think what you are doing here isn't quite
right with regards to frame isolation.

https://codereview.chromium.org/474913003/diff/1/content/browser/wake_lock/wa...
File content/browser/wake_lock/wake_lock_dispatcher_host.h (right):

https://codereview.chromium.org/474913003/diff/1/content/browser/wake_lock/wa...
content/browser/wake_lock/wake_lock_dispatcher_host.h:11: struct
WakeLockRequestInfo;
Where is that declared? CL 399313003 doesn't seem to include that.

Expand Messages | Collapse Messages