Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: mojo/services/view_manager/view_manager_unittest.cc

Issue 474883003: Move focus from the view manager to the window manager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/view_manager/view_manager_unittest.cc
diff --git a/mojo/services/view_manager/view_manager_unittest.cc b/mojo/services/view_manager/view_manager_unittest.cc
index ad790772696d8d34653c9f0c209a8c777c6dc17d..5ea3b71899fcb5709543993c51f242f3e538ee08 100644
--- a/mojo/services/view_manager/view_manager_unittest.cc
+++ b/mojo/services/view_manager/view_manager_unittest.cc
@@ -325,15 +325,12 @@ class TestViewManagerClientConnection
const Callback<void()>& callback) OVERRIDE {
tracker_.OnNodeInputEvent(node_id, event.Pass());
}
- virtual void OnFocusChanged(Id gained_focus_id,
- Id lost_focus_id) OVERRIDE {}
virtual void Embed(
const String& url,
InterfaceRequest<ServiceProvider> service_provider) OVERRIDE {
tracker_.DelegateEmbed(url);
}
- virtual void DispatchOnViewInputEvent(Id node_id,
- mojo::EventPtr event) OVERRIDE {
+ virtual void DispatchOnViewInputEvent(mojo::EventPtr event) OVERRIDE {
}
private:
@@ -1284,10 +1281,5 @@ TEST_F(ViewManagerTest, EmbedWithSameNodeId2) {
// that SetBounsdNodes/AddNode and the like don't result in messages to the
// originating connection.
-// TODO(beng): Add tests for focus:
-// - focus between two nodes known to a connection
-// - focus between nodes unknown to one of the connections.
-// - focus between nodes unknown to either connection.
-
} // namespace service
} // namespace mojo
« no previous file with comments | « mojo/services/view_manager/view_manager_service_impl.cc ('k') | mojo/services/view_manager/window_manager_access_policy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698