Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: mojo/services/view_manager/view_manager_service_impl.cc

Issue 474883003: Move focus from the view manager to the window manager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/view_manager/view_manager_service_impl.cc
diff --git a/mojo/services/view_manager/view_manager_service_impl.cc b/mojo/services/view_manager/view_manager_service_impl.cc
index 1ba2d4aa4a753873b9d6ba5c3f61b08066a59e6e..2311b74e7f7e78e911e3f4a361f577e5556b8bca 100644
--- a/mojo/services/view_manager/view_manager_service_impl.cc
+++ b/mojo/services/view_manager/view_manager_service_impl.cc
@@ -142,24 +142,6 @@ void ViewManagerServiceImpl::ProcessNodeDeleted(const NodeId& node,
}
}
-void ViewManagerServiceImpl::ProcessFocusChanged(const Node* focused_node,
- const Node* blurred_node,
- bool originated_change) {
- if (originated_change)
- return;
-
- // TODO(sky): this should not notify all clients.
- Id focused_id = 0;
- Id blurred_id = 0;
- if (focused_node && IsNodeKnown(focused_node))
- focused_id = NodeIdToTransportId(focused_node->id());
- if (blurred_node && IsNodeKnown(blurred_node))
- blurred_id = NodeIdToTransportId(blurred_node->id());
-
- if (focused_id != 0 || blurred_id != 0)
- client()->OnFocusChanged(focused_id, blurred_id);
-}
-
void ViewManagerServiceImpl::OnConnectionError() {
if (delete_on_connection_error_)
delete this;
@@ -439,17 +421,6 @@ void ViewManagerServiceImpl::SetViewContents(
callback.Run(true);
}
-void ViewManagerServiceImpl::SetFocus(Id view_id,
- const Callback<void(bool)> & callback) {
- bool success = false;
- Node* node = GetNode(NodeIdFromTransportId(view_id));
- if (node && access_policy_->CanSetFocus(node)) {
- success = true;
- node->window()->Focus();
- }
- callback.Run(success);
-}
-
void ViewManagerServiceImpl::SetViewBounds(
Id view_id,
RectPtr bounds,
« no previous file with comments | « mojo/services/view_manager/view_manager_service_impl.h ('k') | mojo/services/view_manager/view_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698