Issue 474813004: IDL: Fix overload resolution for dictionary types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 474813004: IDL: Fix overload resolution for dictionary types (Closed)

Created:
6 years, 4 months ago by Jens Widell

Modified:
6 years, 4 months ago

Reviewers:
haraken, bashi

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

IDL: Fix overload resolution for dictionary types Overload resolution only handled the "Dictionary" type correctly, not actual declared dictionary types. BUG=321462 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180527

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -2 lines)			Patch
M	Source/bindings/scripts/v8_interface.py	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/bindings/tests/idls/TestObject.idl	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestObject.cpp	View	1	3 chunks	+54 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

bashi

On 2014/08/19 06:18:02, Jens Widell wrote: > PTAL LGTM. Thank you for the fix!

6 years, 4 months ago (2014-08-19 06:28:43 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/474813004/20001

6 years, 4 months ago (2014-08-19 07:32:32 UTC) #4

commit-bot: I haz the power

Committed patchset #2 (20001) as 180527

6 years, 4 months ago (2014-08-19 07:36:15 UTC) #5

Message was sent while issue was closed.

LGTM