Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 474813004: IDL: Fix overload resolution for dictionary types (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: the fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/tests/idls/TestObject.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_interface.py
diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py
index 606381a248b8113d6534d61542be0a168f87cf0e..e2355a08985af4acfa7658a4832da29716d2f49a 100644
--- a/Source/bindings/scripts/v8_interface.py
+++ b/Source/bindings/scripts/v8_interface.py
@@ -735,11 +735,10 @@ def resolution_tests_methods(effective_overloads):
# ...
# • a dictionary
try:
- # FIXME: IDL dictionary not implemented, so use Blink Dictionary
- # http://crbug.com/321462
idl_type, method = next((idl_type, method)
for idl_type, method in idl_types_methods
if (idl_type.native_array_element_type or
+ idl_type.is_dictionary or
idl_type.name == 'Dictionary'))
if idl_type.native_array_element_type:
# (We test for Array instead of generic Object to type-check.)
« no previous file with comments | « no previous file | Source/bindings/tests/idls/TestObject.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698