[gcc 4.8] Use EXPECT_FALSE instead of EXPECT_EQ for comparing false

Use EXPECT_FALSE instead of EXPECT_EQ for comparing false

Using EXPECT_EQ(false, condition_expr) assertion gets the following error with gcc 4.8.x toolchain on linux
when building unit test:

error: converting ‘false’ to pointer type for argument 1 of ‘char testing::
internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Werror=conversion-null]

It is a mysterious problem occurred in gtest. Only EXPECT_EQ(false, condition_expr) cause the compile error, while EXPECT_EQ(true, condition_expr) can work well.

BUG=139326
TBR=rkc@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289586

[vivekg, 2014-08-14 04:17:39]

PTAL, thank you!

[vivekg, 2014-08-14 07:59:50]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-08-14 08:02:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/474773003/1

[rkc, 2014-08-14 10:51:19]

lgtm, the change itself is probably a slight improvement; though I am worried
that this bug exists in gtest. Do Chrome maintainers of gtest know about this?

[vivekg, 2014-08-14 10:52:46]

On 2014/08/14 10:51:19, Rahul Chaturvedi wrote:
> lgtm, the change itself is probably a slight improvement; though I am worried
> that this bug exists in gtest. Do Chrome maintainers of gtest know about this?

Thank you! Yes, the maintainers are notified already on the bug.

[commit-bot: I haz the power, 2014-08-14 15:12:08]

Committed patchset #1 (1) as 289586