Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: components/copresence/handlers/audio/audio_directive_handler_unittest.cc

Issue 474773003: [gcc 4.8] Use EXPECT_FALSE instead of EXPECT_EQ for comparing false (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/copresence/handlers/audio/audio_directive_handler_unittest.cc
diff --git a/components/copresence/handlers/audio/audio_directive_handler_unittest.cc b/components/copresence/handlers/audio/audio_directive_handler_unittest.cc
index 7c2994ebbd338492ee6d0297cc68fafe1a9a305b..c2482ddd298a2354eaa255bebc2c4c833be04504 100644
--- a/components/copresence/handlers/audio/audio_directive_handler_unittest.cc
+++ b/components/copresence/handlers/audio/audio_directive_handler_unittest.cc
@@ -121,16 +121,16 @@ TEST_F(AudioDirectiveHandlerTest, Basic) {
EXPECT_EQ(true, directive_handler_->recorder_->IsRecording());
directive_handler_->RemoveInstructions("op_id1");
- EXPECT_EQ(false, directive_handler_->player_audible_->IsPlaying());
+ EXPECT_FALSE(directive_handler_->player_audible_->IsPlaying());
EXPECT_EQ(true, directive_handler_->player_inaudible_->IsPlaying());
EXPECT_EQ(true, directive_handler_->recorder_->IsRecording());
directive_handler_->RemoveInstructions("op_id2");
- EXPECT_EQ(false, directive_handler_->player_inaudible_->IsPlaying());
+ EXPECT_FALSE(directive_handler_->player_inaudible_->IsPlaying());
EXPECT_EQ(true, directive_handler_->recorder_->IsRecording());
directive_handler_->RemoveInstructions("op_id3");
- EXPECT_EQ(false, directive_handler_->recorder_->IsRecording());
+ EXPECT_FALSE(directive_handler_->recorder_->IsRecording());
}
// TODO(rkc): Write more tests that check more convoluted sequences of
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698