Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java

Issue 474573003: Catch and report exceptions in CalledByNative java methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add test asserts. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java
diff --git a/components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java b/components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java
index aef180500f480ae5bf9770b4305581bec06d176d..f9088360b7cc312ffee729b3ecb1b191057592fb 100644
--- a/components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java
+++ b/components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java
@@ -7,9 +7,11 @@ package org.chromium.cronet_sample_apk;
import android.test.suitebuilder.annotation.SmallTest;
import org.chromium.base.test.util.Feature;
+import org.chromium.net.HttpUrlRequest;
import org.chromium.net.HttpUrlRequestFactoryConfig;
import java.io.File;
+import java.util.HashMap;
/**
* Example test that just starts the cronet sample.
@@ -91,6 +93,26 @@ public class CronetSampleUrlTest extends CronetSampleTestBase {
@SmallTest
@Feature({"Cronet"})
+ public void testCalledByNativeException() throws Exception {
+ CronetSampleActivity activity = launchCronetSampleWithUrl(URL);
+
+ // Make sure the activity was created as expected.
+ assertNotNull(activity);
+
+ waitForActiveShellToBeDoneLoading();
+
+ HashMap<String, String> headers = new HashMap<String, String>();
+ // Create request with null listener to trigger an exception.
+ HttpUrlRequest request = activity.mChromiumRequestFactory.createRequest(
+ URL, HttpUrlRequest.REQUEST_PRIORITY_MEDIUM, headers, null);
+ request.start();
+ Thread.sleep(5000);
Charles 2014/08/13 21:17:09 This seems flaky.
mef 2014/08/13 21:34:40 Yeah, what's a good way to make it deterministic?
mef 2014/08/15 14:58:19 Done. Bad Listener also verifies that onRequestCom
+ assertTrue(request.isCanceled());
+ assertNotNull(request.getException());
+ }
+
+ @SmallTest
+ @Feature({"Cronet"})
public void testLegacyLoadUrl() throws Exception {
HttpUrlRequestFactoryConfig config = new HttpUrlRequestFactoryConfig();
config.enableLegacyMode(true);

Powered by Google App Engine
This is Rietveld 408576698