components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java - Issue 474573003: Catch and report exceptions in CalledByNative java methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

Issue 474573003: Catch and report exceptions in CalledByNative java methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add test asserts. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java ('K') | « components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java ('k') | components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java » ('j') | components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

diff --git a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

index 70a61453b50f3aaa369d82ac3af48be8e974a1d1..a15e30f900d205c584b388fb8519850eaebac49b 100644

--- a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

+++ b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

@@ -20,7 +20,7 @@ public class ChromiumUrlRequestContext {

private static final int LOG_NONE = 3; // LOG(FATAL), no VLOG.

private static final int LOG_DEBUG = -1; // LOG(FATAL...INFO), VLOG(1)

private static final int LOG_VERBOSE = -2; // LOG(FATAL...INFO), VLOG(2)

- private static final String LOG_TAG = "ChromiumNetwork";

+ public static final String LOG_TAG = "ChromiumNetwork";

Charles 2014/08/13 21:17:09 No need for public, leaving off the access marker

mef 2014/08/13 21:34:40 Done.

/**

* Native adapter object, owned by ChromiumUrlRequestContext.