Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 474413002: Increase default DevTools request timeout to 30 seconds. (Closed)

Created:
6 years, 4 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 4 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org, dtu, Zhenyao Mo, bajones
Project:
chromium
Visibility:
Public.

Description

Increase default DevTools request timeout to 30 seconds. The timeout was recently changed from None (wait forever) to 5 seconds. On slow bots, even after _WaitForBrowserToComeUp returns, the launch of the first renderer can take considerable time. The next request for the browser's state is subject to the timeout here, and the browser does not respond until the renderer's launch completes. Increasing the timeout to 30 seconds should not regress the original fix and should fix the flakiness. BUG=403981 TBR=tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Russell (switch to Gerrit)
Tony: I'm CQ'ing this TBR'd because the cause is well understood at this point and ...
6 years, 4 months ago (2014-08-16 02:44:40 UTC) #1
Ken Russell (switch to Gerrit)
The CQ bit was checked by kbr@chromium.org
6 years, 4 months ago (2014-08-16 02:44:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/474413002/1
6 years, 4 months ago (2014-08-16 02:45:35 UTC) #3
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 08:23:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (1) as 290133

Powered by Google App Engine
This is Rietveld 408576698