tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py - Issue 474413002: Increase default DevTools request timeout to 30 seconds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

Issue 474413002: Increase default DevTools request timeout to 30 seconds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

index 90d5fd2ddf74c5a94c87a76135fbbb0491472da9..464371595efcb4167fdd10c16b54911d4a680af8 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

@@ -194,7 +194,7 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):

def ListInspectableContexts(self):

return json.loads(self.Request(''))

- def Request(self, path, timeout=5, throw_network_exception=False):

+ def Request(self, path, timeout=30, throw_network_exception=False):

url = 'http://127.0.0.1:%i/json' % self._port

if path:

url += '/' + path

« no previous file with comments | « no previous file | no next file » | no next file with comments »