Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 474323002: IDL: initialize union member variables (to null/zero) (Closed)

Created:
6 years, 4 months ago by Jens Widell
Modified:
6 years, 4 months ago
Reviewers:
haraken, bashi
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: initialize union member variables (to null/zero) Since we now use non-null to represent union member presence, either by wrapping with Nullable<> or using the implicit null value (for pointers and strings,) we must make sure the locals we pass to the implementation are all properly initialized to null. For strings and RefPtr<>/OwnPtr<>, this requires no special care due to default constructors taking care of it. For RawPtr<> (when used in practice, i.e. mostly in Oilpan builds) we need to initialize explicitly. This fixes Oilpan crashes introduced by this CL: https://codereview.chromium.org/466323002/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -13 lines) Patch
M Source/bindings/scripts/v8_methods.py View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/bindings/scripts/v8_types.py View 1 chunk +13 lines, -3 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperations.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Jens Widell
PTAL Note: This also affects code generation for attributes implemented in private scripts (in PrivateScriptTest), ...
6 years, 4 months ago (2014-08-15 19:59:43 UTC) #1
haraken
LGTM
6 years, 4 months ago (2014-08-15 22:33:36 UTC) #2
bashi
On 2014/08/15 22:33:36, haraken wrote: > LGTM LGTM Thank you for the fix!
6 years, 4 months ago (2014-08-16 00:12:25 UTC) #3
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 4 months ago (2014-08-16 06:21:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/474323002/1
6 years, 4 months ago (2014-08-16 06:22:13 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-16 07:23:47 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 07:52:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (1) as 180405

Powered by Google App Engine
This is Rietveld 408576698