Source/bindings/templates/methods.cpp - Issue 474323002: IDL: initialize union member variables (to null/zero)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/methods.cpp

Issue 474323002: IDL: initialize union member variables (to null/zero) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/templates/methods.cpp

diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp

index 1a34416d767768c500c54fe61b0e7a209b161ab3..e33041bb0a4df4aa0bb441c9ceda7aa41767648e 100644

--- a/Source/bindings/templates/methods.cpp

+++ b/Source/bindings/templates/methods.cpp

@@ -297,7 +297,7 @@ if (info.Length() >= 2 && listener && !impl->toNode())

{######################################}

{% macro union_type_method_call_and_set_return_value(method) %}

{% for argument in method.union_arguments %}

-{{argument.cpp_type}} {{argument.cpp_value}};

+{{argument.cpp_type}} {{argument.cpp_value}}{{argument.cpp_type_initializer}};

{% endfor %}

{{method.cpp_value}};

{% if method.is_null_expression %}{# used by getters #}

« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »