Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 47403003: Revert 231982 "Docserver: Display enum value descriptions in API..." (Closed)

Created:
7 years, 1 month ago by kinaba
Modified:
7 years, 1 month ago
Reviewers:
Sam McNally
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 231982 "Docserver: Display enum value descriptions in API..." "JsonSchemaTest.TestEnum" started failing on Windows bot after this change. > Docserver: Display enum value descriptions in API docs. > > This modifies the json schema to allow both primitive types and > dictionaries with properties "name" and optional "description" for enum > values. > > BUG=310454 > > Review URL: https://codereview.chromium.org/39113003 TBR=sammc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232016

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -104 lines) Patch
M trunk/src/chrome/common/extensions/docs/server2/api_data_source.py View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/common/extensions/docs/server2/app.yaml View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/common/extensions/docs/server2/cron.yaml View 1 chunk +1 line, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/private/enum_descriptions.html View 1 chunk +0 lines, -16 lines 0 comments Download
M trunk/src/chrome/common/extensions/docs/templates/private/property.html View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/common/extensions/docs/templates/private/type.html View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/renderer/resources/extensions/json_schema.js View 2 chunks +2 lines, -7 lines 0 comments Download
M trunk/src/chrome/test/data/extensions/json_schema_test.js View 1 chunk +3 lines, -4 lines 0 comments Download
M trunk/src/components/json_schema/json_schema_validator.cc View 3 chunks +0 lines, -25 lines 0 comments Download
M trunk/src/components/json_schema/json_schema_validator_unittest.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M trunk/src/components/test/data/json_schema/enum_schema.json View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/tools/json_schema_compiler/cc_generator.py View 3 chunks +3 lines, -5 lines 0 comments Download
M trunk/src/tools/json_schema_compiler/cpp_type_generator.py View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/tools/json_schema_compiler/idl_schema.py View 1 chunk +1 line, -7 lines 0 comments Download
M trunk/src/tools/json_schema_compiler/idl_schema_test.py View 2 chunks +3 lines, -7 lines 0 comments Download
M trunk/src/tools/json_schema_compiler/model.py View 2 chunks +1 line, -15 lines 0 comments Download
M trunk/src/tools/json_schema_compiler/test/idl_basics.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
kinaba
7 years, 1 month ago (2013-10-31 06:38:20 UTC) #1
kinaba
7 years, 1 month ago (2013-10-31 06:38:33 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r232016.

Powered by Google App Engine
This is Rietveld 408576698