trunk/src/components/json_schema/json_schema_validator_unittest.cc - Issue 47403003: Revert 231982 "Docserver: Display enum value descriptions in API..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/components/json_schema/json_schema_validator_unittest.cc

Issue 47403003: Revert 231982 "Docserver: Display enum value descriptions in API..." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trunk/src/components/json_schema/json_schema_validator_unittest.cc

===================================================================

--- trunk/src/components/json_schema/json_schema_validator_unittest.cc (revision 232015)

+++ trunk/src/components/json_schema/json_schema_validator_unittest.cc (working copy)

@@ -77,16 +77,10 @@

EXPECT_FALSE(JSONSchemaValidator::IsValidSchema(

"{"

" \"type\": \"string\","

- " \"enum\": [ {} ]" // "enum" dict values must contain "name".

+ " \"enum\": [ {} ]," // "enum" must contain simple values.

"}", &error));

EXPECT_FALSE(JSONSchemaValidator::IsValidSchema(

"{"

- " \"type\": \"string\","

- " \"enum\": [ { \"name\": {} } ]" // "enum" name must be a simple value.

- "}",

- &error));

- EXPECT_FALSE(JSONSchemaValidator::IsValidSchema(

- "{"

" \"type\": \"array\","

" \"items\": [ 123 ]," // "items" must contain a schema or schemas.

"}", &error));

@@ -112,7 +106,7 @@

" },"

" \"enum-property\": {"

" \"type\": \"integer\","

- " \"enum\": [0, 1, {\"name\": 10}, 100]"

+ " \"enum\": [0, 1, 10, 100]"

" },"

" \"items-property\": {"

" \"type\": \"array\","