Issue 473923002: DevTools: Prevent a debugger pause while executing js code in releaseObjectGroup

Issue 473923002: DevTools: Prevent a debugger pause while executing js code in releaseObjectGroup (Closed)

Created:
6 years, 4 months ago by sergeyv

Modified:
6 years, 4 months ago

Reviewers:
vsevik, aandrey, yurys, Yang

CC:
blink-reviews, vsevik+blink_chromium.org, caseq+blink_chromium.org, arv+blink, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, loislo+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Prevent a debugger pause while executing js code in releaseObjectGroup V8 part of change: https://codereview.chromium.org/473913002 BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180847

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address aandrey's comment #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -2 lines)			Patch
M	Source/bindings/core/v8/ScriptDebugServer.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/core/v8/ScriptDebugServer.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorRuntimeAgent.cpp	View	1	1 chunk	+13 lines, -2 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

aandrey

lgtm https://codereview.chromium.org/473923002/diff/1/Source/core/inspector/InspectorRuntimeAgent.cpp File Source/core/inspector/InspectorRuntimeAgent.cpp (right): https://codereview.chromium.org/473923002/diff/1/Source/core/inspector/InspectorRuntimeAgent.cpp#newcode145 Source/core/inspector/InspectorRuntimeAgent.cpp:145: injectedScript.releaseObject(objectId); I think this should be also wrapped ...

6 years, 4 months ago (2014-08-17 17:40:41 UTC) #4

Yang

drive-by https://codereview.chromium.org/473923002/diff/1/Source/bindings/core/v8/ScriptDebugServer.cpp File Source/bindings/core/v8/ScriptDebugServer.cpp (right): https://codereview.chromium.org/473923002/diff/1/Source/bindings/core/v8/ScriptDebugServer.cpp#newcode180 Source/bindings/core/v8/ScriptDebugServer.cpp:180: bool ScriptDebugServer::pausingOnNextStatement() This name is somewhat misleading. Interrupts ...

6 years, 4 months ago (2014-08-18 09:30:23 UTC) #5

sergeyv

https://codereview.chromium.org/473923002/diff/1/Source/core/inspector/InspectorRuntimeAgent.cpp File Source/core/inspector/InspectorRuntimeAgent.cpp (right): https://codereview.chromium.org/473923002/diff/1/Source/core/inspector/InspectorRuntimeAgent.cpp#newcode145 Source/core/inspector/InspectorRuntimeAgent.cpp:145: injectedScript.releaseObject(objectId); On 2014/08/17 17:40:41, aandrey wrote: > I think ...

6 years, 4 months ago (2014-08-25 11:37:31 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/473923002/20001

6 years, 4 months ago (2014-08-25 11:38:34 UTC) #8

commit-bot: I haz the power

6 years, 4 months ago (2014-08-25 12:37:36 UTC) #9

Message was sent while issue was closed.

Committed patchset #2 (20001) as 180847

Expand Messages | Collapse Messages