Expose function CheckDebugBreak in the debugger api

Expose function CheckDebugBreak in the debugger api

API=v8::Debug::CheckDebugBreak
LOG=Y
R=aandrey@chromium.org, vsevik@chromium.org, yurys@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=23227

[yurys, 2014-08-14 13:52:25]

lgtm

[sergeyv, 2014-08-14 14:04:52]

+yangguo, Please take a look

[vsevik, 2014-08-14 16:26:43]

lgtm

[aandrey, 2014-08-17 17:38:16]

lgtm

https://codereview.chromium.org/473913002/diff/1/include/v8-debug.h
File include/v8-debug.h (right):

https://codereview.chromium.org/473913002/diff/1/include/v8-debug.h#newcode170
include/v8-debug.h:170: // Check if a debugger break is scheduled in the given
isolate
nit: dot at the end

[Yang, 2014-08-18 09:27:50]

On 2014/08/17 17:38:16, aandrey wrote:
> lgtm
> 
> https://codereview.chromium.org/473913002/diff/1/include/v8-debug.h
> File include/v8-debug.h (right):
> 
> https://codereview.chromium.org/473913002/diff/1/include/v8-debug.h#newcode170
> include/v8-debug.h:170: // Check if a debugger break is scheduled in the given
> isolate
> nit: dot at the end

LGTM except for the nit Andrey pointed out.

[sergeyv, 2014-08-18 12:23:39]

https://codereview.chromium.org/473913002/diff/1/include/v8-debug.h
File include/v8-debug.h (right):

https://codereview.chromium.org/473913002/diff/1/include/v8-debug.h#newcode170
include/v8-debug.h:170: // Check if a debugger break is scheduled in the given
isolate
On 2014/08/17 21:38:16, aandrey wrote:
> nit: dot at the end

Done.

[sergeyv, 2014-08-18 12:23:49]

The CQ bit was checked by sergeyv@chromium.org

[commit-bot: I haz the power, 2014-08-18 12:24:43]

CQ is trying da patch. Follow status at
 https://v8-status.appspot.com/cq/sergeyv@chromium.org/473913002/20001

[commit-bot: I haz the power, 2014-08-18 12:24:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-18 12:24:44]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Yang, 2014-08-18 12:25:41]

On 2014/08/18 12:24:44, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a provisional committer, _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

Unfortunately, CQ doesn't work with V8. I'll land this CL once the V8 tree is
not throttled any longer (due to Chrome branching).

[sergeyv, 2014-08-18 12:27:33]

On 2014/08/18 12:25:41, Yang wrote:
> On 2014/08/18 12:24:44, I haz the power (commit-bot) wrote:
> > No LGTM from a valid reviewer yet. Only full committers are accepted.
> > Even if an LGTM may have been provided, it was from a non-committer or
> > a provisional committer, _not_ a full super star committer.
> > See http://www.chromium.org/getting-involved/become-a-committer
> > Note that this has nothing to do with OWNERS files.
> 
> Unfortunately, CQ doesn't work with V8. I'll land this CL once the V8 tree is
> not throttled any longer (due to Chrome branching).

Ok, thank you!

[Yang, 2014-08-20 11:04:13]

Committed patchset #2 manually as 23227 (presubmit successful).