Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 473893002: Add 'idl_name' to IdlDefinition, IdlOperation, IdlAttribute etc (Closed)

Created:
6 years, 4 months ago by haraken
Modified:
6 years, 4 months ago
Reviewers:
Jens Widell, tasak
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Add 'idl_name' to IdlDefinition, IdlOperation, IdlAttribute etc IdlDefinition, IdlOperation, IdlAttribute etc should know the name of an IDL file where they are defined. We want to pass these names to PrivateScriptRunner's methods so that PrivateScriptRunner can understand the names of JS files of the DOM attributes/methods that the PrivateScriptRunner is running. Binding componentization for partial interfaces also need this change. BUG=341031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180275

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -56 lines) Patch
M Source/bindings/scripts/idl_definitions.py View 29 chunks +66 lines, -54 lines 0 comments Download
M Source/bindings/scripts/idl_reader.py View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/scripts/v8_interface.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
haraken
jl@: PTAL I'll make a change to the code generator in the next CL.
6 years, 4 months ago (2014-08-14 11:44:21 UTC) #1
Jens Widell
LGTM Note that you can also get the filename from the node, using node.GetProperty('FILENAME'). That's ...
6 years, 4 months ago (2014-08-14 11:54:55 UTC) #2
haraken
On 2014/08/14 11:54:55, Jens Widell wrote: > LGTM > > Note that you can also ...
6 years, 4 months ago (2014-08-14 13:41:16 UTC) #3
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 4 months ago (2014-08-14 13:41:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/473893002/1
6 years, 4 months ago (2014-08-14 13:42:47 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 15:46:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 180275

Powered by Google App Engine
This is Rietveld 408576698